Skip to content

fix: rust-cssparser0.31: fix upstream-name to match component name #16490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Apr 7, 2026
+1 −1
Merged

fix: rust-cssparser0.31: fix upstream-name to match component name #16490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/comps/rust-cssparser0.31/rust-cssparser0.31.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line changes the upstream-commit pin, but the surrounding comment block doesn’t include a reference URL to the Fedora dist-git commit being pinned (recommended for traceability), and the PR description only mentions upstream-name. Please add a full Fedora dist-git commit URL for the new hash and briefly note in the PR description why the pin changed.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-cssparser0.31/c/d80ba243544c8347a14ed079b787dd09d9fba0bd

Copilot uses AI. Check for mistakes.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" }
spec = { type = "upstream", upstream-name = "rust-cssparser0.31", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec.upstream-name should refer to the Fedora dist-git package name (i.e., the component name in the upstream distro). For version-suffixed Rust components in this repo, upstream-name typically omits the version suffix (e.g., rust-selectors0.25 uses upstream-name = "rust-selectors"). Setting upstream-name = "rust-cssparser0.31" is likely to point to a non-existent Fedora dist-git repo and break azldev source fetching/builds; consider reverting to upstream-name = "rust-cssparser".

Suggested change
spec = { type = "upstream", upstream-name = "rust-cssparser0.31", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" }
spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" }

Copilot uses AI. Check for mistakes.
Loading