Refactor VideoSerializationHandler for asset properties

[dpfaffenbauer]

Refactored video asset serialization to use private methods for duration, width, and height retrieval with error handling.

Changes in this pull request

Resolves pimcore/platform-version#245

Additional info

[pimcore-deployments]

🚫 CI & merge-readiness guardrail failed — this PR has been converted to draft.

A PR can only be merged when it has no conflicts with the base branch and all CI checks pass.

• CI check not successful: SonarCloud Code Analysis (failure).

When fixed, press Ready for review to re-run the checks.

[Copilot]

Pull request overview

This PR refactors VideoSerializationHandler so that the duration, width, and height of a video asset are read through dedicated private methods that wrap the getter calls in try/catch and log errors instead of letting exceptions propagate during serialization. It follows the existing pattern already used by getImageThumbnail() in the same class.

Changes:

• Replace direct $asset->getDuration()/getWidth()/getHeight() calls in getAdditionalSystemFields() with calls to new private helpers.
• Add getDuration(), getWidth(), and getHeight() helpers that catch Exception and log a failure message.

Comments suppressed due to low confidence (1)

src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php:109

• $video is undefined here — the parameter of this method is named $asset. In the catch path this accesses an undefined variable and then calls getId() on null, which throws an Error that is not caught by catch (Exception), so the error-logging path itself crashes. Use $asset->getId().

                $video->getId() .

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)
1 New Critical Issues (required ≤ 0)
3 New Major Issues (required ≤ 0)
3 New Bugs (required ≤ 0)
3 New Blocker Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE