Skip to content

Refactor VideoSerializationHandler for asset properties #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dpfaffenbauer wants to merge 4 commits into
base: 2026.x
Choose a base branch
from
+51 −1
Draft

Refactor VideoSerializationHandler for asset properties #481

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
084eb29
Refactor VideoSerializationHandler for asset properties
dpfaffenbauer Jul 23, 2026
001d051
Fix error logging in VideoSerializationHandler
dpfaffenbauer Jul 23, 2026
674779f
Update VideoSerializationHandler.php
dpfaffenbauer Jul 23, 2026
d7cc3f8
Merge branch '2026.x' into patch-1
dpfaffenbauer Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@
{
use LoggerAwareTrait;

private const ERROR_SEPARATOR = ' error ';

Check failure on line 29 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " error " 4 times. 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQH&open=AZ-t5ouLUb9ocBXs6hQH&pullRequest=481

/**
* @throws Exception
*/
public function getAdditionalSystemFields(Asset $asset): array
{
if (!$asset instanceof Video) {
Expand Down Expand Up @@ -56,7 +61,52 @@
} catch (Throwable $e) {
$this->logger->error('Thumbnail generation failed for video asset: ' .
$video->getId() .
' error ' .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}

return null;
}

private function getDuration(Video $asset): ?int

Check warning on line 72 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unused private "getduration" method. 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQB&open=AZ-t5ouLUb9ocBXs6hQB&pullRequest=481
{
try {
return $asset->getDuration();
} catch (Exception $e) {

Check failure on line 76 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Create class "Exception" in namespace or check correct import of class 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQE&open=AZ-t5ouLUb9ocBXs6hQE&pullRequest=481
$this->logger->error('Failed getting duration for video asset: ' .
$asset->getId() .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}

return null;
}

private function getWidth(Video $asset): ?int

Check warning on line 87 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unused private "getwidth" method. 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQC&open=AZ-t5ouLUb9ocBXs6hQC&pullRequest=481
{
try {
return $asset->getWidth();
} catch (Exception $e) {

Check failure on line 91 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Create class "Exception" in namespace or check correct import of class 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQF&open=AZ-t5ouLUb9ocBXs6hQF&pullRequest=481
$this->logger->error('Failed getting width for video asset: ' .
$asset->getId() .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}

return null;
}

private function getHeight(Video $asset): ?int

Check warning on line 102 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unused private "getheight" method. 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQD&open=AZ-t5ouLUb9ocBXs6hQD&pullRequest=481
{
try {
return $asset->getHeight();
} catch (Exception $e) {

Check failure on line 106 in src/Service/Serializer/AssetTypeSerializationHandler/VideoSerializationHandler.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Create class "Exception" in namespace or check correct import of class 


See more on https://sonarcloud.io/project/issues?id=pimcore_generic-data-index-bundle&issues=AZ-t5ouLUb9ocBXs6hQG&open=AZ-t5ouLUb9ocBXs6hQG&pullRequest=481
$this->logger->error('Failed getting height for video asset: ' .
$asset->getId() .
self::ERROR_SEPARATOR .
$e->getMessage()
);
}
Expand Down
Loading