-
Notifications
You must be signed in to change notification settings - Fork 80
Upgrade to Bazel 7.7.1 with modern clang-tidy integration and bzlmod-ready dependencies #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bazel/repositories.bzl
Outdated
| url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.7.1.tar.gz", | ||
| sha256 = "32759728913c376ba45b0116869b71b68b1c2ebf8f2bcf7b41222bc07b773d73", | ||
| strip_prefix = "rules_foreign_cc-0.15.1", | ||
| url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.15.1.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like foreign_cc >=0.14.0 requires multiple additional external dependencies.
0.13.0 appears to be a drop-in replacement without additional dependencies, if that is new enough for macos 15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.13.0 needs bazel feature too it seems
896c6af to
b7f9cdc
Compare
…ready dependencies Signed-off-by: Matthieu MOREL <[email protected]>
|
Hi @mmorel-35, do you mind if I push a few commits onto your branch? I think I might be able to resolve some of the build issues. |
|
Take all you need. I won’t be able to do anything in the next weeks . Feel free to proceed . |
* rules_python -> 1.6.1, * rust toolchain -> 1.91, * python toolchain -> 3.11, * rules_cc -> 0.1.5, * rules_foreign_cc -> 0.15.1, * rules_rust -> 0.68.1 Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Major Changes
Bazel Upgrade
Linting System Modernization
//tools/lint:linters.bzl%clang_tidy)Bzlmod Preparation (from native-bind and platforms branches)
native.bind()calls removed from bazel/repositories.bzl. BUILD file now references dependencies directly using canonical labels (e.g.,@v8//:wee8instead of//external:wee8)Dependency Updates
New Dependencies for Modern Linting
WORKSPACE Configuration
Standard load order maintained:
Infrastructure Changes
tools/lint/BUILDwith hermetic clang-tidy binary configurationtools/lint/linters.bzlwith clang_tidy aspect configurationnative.bind()calls and updated BUILD file to use canonical dependency labelsBuild Validation
✅ Bazel Upgrade: Successfully upgraded to 7.7.1
✅ Linting Infrastructure: Modern aspect_rules_lint integration configured
✅ Main Library Build:
bazel build --config clang-tidy //:libcompletes successfully✅ C++ Tests: Build successfully with clang-tidy
✅ Bzlmod Preparation: native.bind() removed, direct dependency references working
Fixes #466
Fixes #467
Fixes #468