Fix test_metastore_get_identity flaky test
#6055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
approved these changes
Jan 2, 2026
| ", | ||
| INSERT INTO kv (key, value) | ||
| VALUES ('cluster_identity', $1) | ||
| ON CONFLICT (key) DO UPDATE SET key = EXCLUDED.key |
Contributor
There was a problem hiding this comment.
til about the virtual EXCLUDED table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test always succeeds when run in isolation but is flaky when multiple tests are executed simultaneously because the pattern insert with CTE followed by SELECT ... is not atomic. Here's Gemini explanation:
How was this PR tested?
Ran this multiple times:
QW_TEST_DATABASE_URL=postgres://[...] c t --manifest-path quickwit/Cargo.toml -p quickwit-metastore --all-features --