Skip to content

Fix test_metastore_get_identity flaky test #6055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guilload wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix test_metastore_get_identity flaky test #6055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,15 +1670,15 @@ impl MetastoreService for PostgresqlMetastore {
&self,
_: GetClusterIdentityRequest,
) -> MetastoreResult<GetClusterIdentityResponse> {
// `ON CONFLICT DO NOTHING RETURNING` returns NULL if no insert happens.
// To always get the value, we use this pattern:
let (uuid,) = sqlx::query_as(
r"
WITH insert AS (
INSERT INTO kv (key, value)
VALUES ('cluster_identity', $1)
ON CONFLICT (key) DO NOTHING
)
SELECT value FROM kv where key = 'cluster_identity';
",
INSERT INTO kv (key, value)
VALUES ('cluster_identity', $1)
ON CONFLICT (key) DO UPDATE SET key = EXCLUDED.key
Copy link
Contributor

@trinity-1686a trinity-1686a Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

til about the virtual EXCLUDED table

RETURNING value
",
)
.bind(Uuid::new_v4().hyphenated().to_string())
.fetch_one(&self.connection_pool)
Expand Down