[Symfony 7.3] Gate GetFiltersAndFunctionsToAsTwigAttributeRector on symfony/twig-bridge 7.3, not twig alone - #1050
Merged
Conversation
…ymfony/twig-bridge 7.3, not twig alone
TomasVotruba
enabled auto-merge (squash)
August 20, 2026 15:43
…to match new constraint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9856.
Problem
GetFiltersAndFunctionsToAsTwigAttributeRectorwas bonded totwig/twig >=3.21only. But the attributes it introduces (#[AsTwigFilter],#[AsTwigFunction],#[AsTwigTest]) are autoregistered by Symfony only from 7.3 (symfony/twig-bridge). On Symfony 6.4 with twig 3.28, the twig constraint passes, the rule stripsTwigExtension+getFilters()/getFunctions(), and every filter/function silently disappears.Fix
Gate on both packages, so the rule runs only where the attributes actually work:
Depends on
Multiple-constraint support: rectorphp/rector-src#8355. CI here stays red until that merges into
rector-srcmain(pulled asdev-main).