Skip to content

[Symfony 7.3] Gate GetFiltersAndFunctionsToAsTwigAttributeRector on symfony/twig-bridge 7.3, not twig alone #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 4 commits into from
Aug 20, 2026
Merged

[Symfony 7.3] Gate GetFiltersAndFunctionsToAsTwigAttributeRector on symfony/twig-bridge 7.3, not twig alone #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27cd856
[Symfony 7.3] Gate GetFiltersAndFunctionsToAsTwigAttributeRector on s…
TomasVotruba Aug 20, 2026
ad5e9cb
[rector] Rector fixes
actions-user Aug 20, 2026
7b9d0a6
Retrigger CI on updated rector-src dev-main
TomasVotruba Aug 20, 2026
86ef149
[Symfony 7.3] Pin symfony/twig-bridge 7.3 in rule test composer.json …
TomasVotruba Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/sets/symfony/composer-based.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@
// symfony/validator 8.1
ConstraintValidatorValidateToValidateInContextRector::class,

// twig/twig 3.21
// twig/twig 3.21 + symfony/twig-bridge 7.3
GetFiltersAndFunctionsToAsTwigAttributeRector::class,

// jms/serializer 3.14
Expand Down
3 changes: 2 additions & 1 deletion ...ymfony73/Rector/Class_/GetFiltersAndFunctionsToAsTwigAttributeRector/config/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"require": {
"twig/twig": "^3.21"
"twig/twig": "^3.21",
"symfony/twig-bridge": "^7.3"
}
}
12 changes: 10 additions & 2 deletions rules/Symfony73/Rector/Class_/GetFiltersAndFunctionsToAsTwigAttributeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,17 @@ public function __construct(
) {
}

public function provideComposerPackageConstraint(): ComposerPackageConstraint
/**
* @return ComposerPackageConstraint[]
*/
public function provideComposerPackageConstraint(): array
{
return new ComposerPackageConstraint('twig/twig', '>=3.21');
// the #[AsTwig*] attributes exist in twig/twig 3.21, but Symfony only autoregisters extension-less
// classes from them in symfony/twig-bridge 7.3; without both, the stripped TwigExtension is silently lost
return [
new ComposerPackageConstraint('twig/twig', '>=3.21'),
new ComposerPackageConstraint('symfony/twig-bridge', '>=7.3'),
];
}

public function getRuleDefinition(): RuleDefinition
Expand Down
Loading