RI-8277 Migrate rdi pipeline-management to i18n#6223
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05cdc0c885
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Coverage - Frontend unit tests
Test suite run success7829 tests passing in 865 suites. Report generated by 🧪jest coverage report action from 442deac |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8399102. Configure here.
8399102 to
2d41c12
Compare
Route the RDI pipeline-management surface through i18n under rdi.pipeline.* with Bulgarian translations: navigation, config & job editor pages, dry-run panel, test-connections panel & log, template form/popover/button, and the upload/download modals. Shared rdiErrorMessages resolves via the i18n singleton; TestConnectionsLog headers via a render-time getColumns(t); <Trans> for doc links and <br/> tooltips. The template "No template" fallback option is built at render (useMemo[t]) instead of a module-level i18n.t so it follows the active language. Rebased onto main after #6221/#6219/#6224 merged; rdi.* locale keys merged and sorted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2d41c12 to
289c693
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 289c6931d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…277) Address review feedback: validateZip threw localized strings and the catch reused that message for the RDI_PIPELINE_UPLOAD_FAILED telemetry event, so the same failure reported different values per locale and split upload analytics. Throw canonical English messages (sent as-is to telemetry) and translate only the displayed error via a canonical->key map, falling back to the raw message for other errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2 participants
What
Routes the RDI pipeline-management surface through i18next under
rdi.pipeline.*(80 keys), with Bulgarian translations added toen.json/bg.json(parity kept). Final rdi PR for the i18n epic (RI-8269).Covered:
<Trans>), test-connection button, loading, dry-run button, SQL/JMESPath editor button.<br/>via<Trans>), aria-labels, no-commands / no-transformation messages, invalid-input tooltip.Testing
yarn testforredisinsight/ui/src/pages/rdi/pipeline-management— 164 tests pass.yarn lint:ui,yarn type-check,yarn i18n:checkall clean.?lang=bgto preview Bulgarian.Closes RI-8277
🤖 Generated with Claude Code
Note
Low Risk
Presentation-only i18n wiring with no changes to pipeline deploy, upload, or API behavior; risk is limited to missing keys or locale-specific copy regressions.
Overview
Moves all user-visible copy on the RDI pipeline-management flow from hard-coded English strings to i18next under
rdi.pipeline.*, with matching entries inen.jsonandbg.json(~80 keys).Pipeline management pages and modals (navigation, config/job editors, dry-run, test connections, templates, upload/download, source picker) now use
useTranslation,Transfor inline doc links and multi-line tooltips, andi18n.twhere hooks are not available (e.g. job name validation, shared error helpers). Upload zip validation still uses stable internal error tokens, then maps known messages to translated labels for display.Template “No template” select options are built at render time via
useMemoso the label follows the active locale; the old module-levelNO_OPTIONSconstant was removed.Reviewed by Cursor Bugbot for commit 442deac. Bugbot is set up for automated code reviews on this repo. Configure here.