chore: deploy patch by MasterPtato · Pull Request #4324 · rivet-dev/rivet

MasterPtato · 2026-02-27T03:18:07Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

railway-app · 2026-02-27T03:18:19Z

🚅 Deployed to the rivet-pr-4324 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
frontend-cloud	😴 Sleeping (View Logs)	Web	Mar 4, 2026 at 10:12 pm
website	😴 Sleeping (View Logs)	Web	Mar 1, 2026 at 2:18 am
frontend-inspector	😴 Sleeping (View Logs)	Web	Feb 28, 2026 at 9:08 pm
ladle	❌ Build Failed (View Logs)	Web	Feb 27, 2026 at 3:30 am
mcp-hub	✅ Success (View Logs)	Web	Feb 27, 2026 at 3:19 am

MasterPtato · 2026-02-27T03:18:22Z

chore: bump rivetkit protocol version #4329
fix(udb): add txn tagging #4328
fix(api): make actor destroy wait for ack #4327
chore: flatten runtime config #4326
chore: deploy patch #4324 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-02-27T03:20:48Z

PR Review: chore: deploy patch

Summary: Small, focused operational patch covering five files: a workflow builder escape hatch for bypassing the dispatch-from-operation restriction, tag additions to the epoxy purge cache workflow dispatch, tag additions for the pegboard serverless receiver, log level adjustments for guard-core and NATS pool, and a new async_nats log filter directive.

Issues

1. Method name inconsistency: `bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING` on `WorkflowBuilder`

File: engine/packages/gasoline/src/builder/common/workflow.rs

The method name says signal but it bypasses the restriction on dispatching workflows from within an operation context. The same name on a SignalBuilder would make sense, but on WorkflowBuilder it is misleading. A reader of the call site in purge_optimistic_cache will need to understand both the workflow and signal bypass separately. Consider renaming the WorkflowBuilder variant to bypass_dispatch_from_op_I_KNOW_WHAT_IM_DOING to match what it actually bypasses.

2. Structured logging violation in touched line

File: engine/packages/guard-core/src/server.rs (line 115)

The changed line (downgraded from error! to warn!) still uses positional format strings instead of tracing fields:

// Current (violates CLAUDE.md convention)
tracing::warn!("{} connection error: {}", port_type_str, err);

// Should be
tracing::warn!(%err, port_type = %port_type_str, "connection error");

CLAUDE.md is explicit: "Do not format parameters into the main message, instead use tracing's structured logging." The same pattern on line 117 (tracing::debug!) was not changed but has the same issue. Since this line was actively edited, fixing the structured logging convention here as well would have been the right time to do so.

Minor Notes

The bypass escape hatch design is acceptable. The deliberately alarming method name, the // TODO: Get rid of this (RVT-5281) comment referencing the tracking ticket, and the inline // NOTE: This is a bad implementation... callout are all good practices for temporary workarounds that need to be tracked.
No tests added for the new method. The PR checklist acknowledges this. A test verifying that the bypass only clears CannotDispatchFromOpInWorkflow (and not other error variants) would be useful to prevent regressions when the bypass is eventually replaced.
Log level changes are well-reasoned. The NATS Closed event downgrade from error! to info! with the // Engine is shutting down, not an error comment is clear and correctly motivated. The guard connection error downgrade from error! to warn! is appropriate for edge-level connection drops.
Tag additions in pegboard receiver correctly extend the workflow's lookup/deduplication surface by namespace_id and runner_name, matching the workflow input fields.
Pre-existing glob import (not introduced by this PR) in engine/packages/epoxy/src/ops/propose.rs line 1: use anyhow::*;. CLAUDE.md states "Do not glob import (::\*) from anyhow." Not a blocker for this PR but worth noting for a follow-up cleanup.

Summary

The one actionable item before merge is the structured logging violation on the actively changed line in guard-core/src/server.rs:115. The method naming inconsistency on WorkflowBuilder::bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING is worth addressing since the escape hatch is explicitly tracked for removal (so the name can be corrected in the same cleanup). All other changes are well-motivated and correctly implemented.

pkg-pr-new · 2026-02-27T03:21:39Z

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4324

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4324

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4324

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4324

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4324

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4324

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4324

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4324

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4324

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4324

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4324

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4324

commit: 20e85fc

MasterPtato · 2026-02-28T00:23:16Z

This change is part of the following stack:

chore: deploy patch #4324 ◀
- chore: flatten runtime config #4326
  - fix(api): make actor destroy wait for ack #4327
    - fix(udb): add txn tagging #4328
      - chore: bump rivetkit protocol version #4329
        
        fix(ups): formalize subjects #4334
        
        fix(api): properly dedup name list responses #4337
        
        fix(pb): clear actor reschedule ts on alloc #4338

_{Change managed by git-spice.}

MasterPtato requested a review from NathanFlurry February 27, 2026 03:18

railway-app bot had a problem deploying to rivet-frontend / rivet-pr-4324 February 27, 2026 03:18 Failure

This was referenced Feb 27, 2026

chore: flatten runtime config #4326

Open

fix(udb): add txn tagging #4328

Open

fix(api): make actor destroy wait for ack #4327

Open

chore: bump rivetkit protocol version #4329

Open

MasterPtato mentioned this pull request Mar 2, 2026

fix(ups): formalize subjects #4334

Draft

11 tasks

chore: deploy patch

cf84ca2

MasterPtato force-pushed the 02-26-chore_deploy_patch branch from 8d1ae7d to cf84ca2 Compare March 3, 2026 00:06

This was referenced Mar 3, 2026

fix(api): properly dedup name list responses #4337

Open

fix(pb): clear actor reschedule ts on alloc #4338

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: deploy patch#4324

chore: deploy patch#4324
MasterPtato wants to merge 1 commit intomainfrom
02-26-chore_deploy_patch

MasterPtato commented Feb 27, 2026

Uh oh!

railway-app bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Feb 27, 2026 •

edited

Loading

Uh oh!

claude bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Feb 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

MasterPtato commented Feb 27, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

railway-app bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

claude bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: chore: deploy patch

Issues

1. Method name inconsistency: bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING on WorkflowBuilder

2. Structured logging violation in touched line

Minor Notes

Summary

Uh oh!

pkg-pr-new bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

railway-app bot commented Feb 27, 2026 •

edited

Loading

MasterPtato commented Feb 27, 2026 •

edited

Loading

claude bot commented Feb 27, 2026 •

edited

Loading

1. Method name inconsistency: `bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING` on `WorkflowBuilder`

pkg-pr-new bot commented Feb 27, 2026 •

edited

Loading

MasterPtato commented Feb 28, 2026 •

edited

Loading