fix(udb): add txn tagging#4328
fix(udb): add txn tagging#4328MasterPtato wants to merge 1 commit into02-27-fix_api_make_actor_destroy_wait_for_ackfrom
Conversation
|
🚅 Deployed to the rivet-pr-4328 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: fix(udb): add txn taggingThis is a small, focused change that adds transaction tagging support to the UniversalDB abstraction layer. SummaryThe PR adds a tag method to the TransactionDriver trait with a default no-op implementation, and exposes it through the public Transaction::tag API. Whats Good
Observations / Minor Notes
VerdictLGTM. The change is correct, minimal, and follows existing patterns. The default no-op on the trait is the right extensibility mechanism for this kind of optional driver capability. |
|
This change is part of the following stack: Change managed by git-spice. |
ec5ffcb to
c88c25b
Compare
011705e to
3472163
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: