Sol/add limits on subkeys sol trigger - #712
Open
Unheilbar wants to merge 10 commits into
Open
Conversation
* Solana actions initial implementation * implement GetProgramAccounts * add unit tests for actions * bump common * add sorting for GetProgramAccounts * run tidy * mark external requests * update cl solana ref * bump sol ref * Wire Slots for GetFee, GetBalance
* Solana actions initial implementation * implement GetProgramAccounts * add unit tests for actions * bump common * add sorting for GetProgramAccounts * run tidy * mark external requests * update cl solana ref * bump sol ref * Implement monitoring context * bump common * onobard v2 monitoring wip * implement new monitoring context * populate local chain info * rm tests * bump common * add read actions limits * rm local replace * fix linter
* add cursor pagination for solana LogTrigger polling * fix unit tests * run modgraph
* bump common * chore: empty commit to retrigger CI * pull solana * bump solana
* add return slot on GetBalance endpoint * make modgraph
product-security-plaid-production
Bot
requested review from
dhaidashenko and
silaslenihan
August 3, 2026 11:45
dhaidashenko
reviewed
Aug 3, 2026
| if len(config.ContractIdlJson) == 0 { | ||
| return fmt.Errorf("event idl json cannot be empty") | ||
| } | ||
| if len(config.Subkeys) > maxSubkeysPerTrigger { |
Contributor
There was a problem hiding this comment.
subkeys are 2d slices. Should we enforce a limit for both dimensions?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.