Skip to content

Sol/add limits on subkeys sol trigger #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Unheilbar wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Sol/add limits on subkeys sol trigger #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf12ab5
PLEX-2404 implement solana actions (#638)
Unheilbar Jun 12, 2026
553c379
PLEX-3061 Limit Response Size Solana actions (#668)
Unheilbar Jun 23, 2026
835c9b5
bump common (#669)
Unheilbar Jun 23, 2026
7da0b6a
bump solana
Unheilbar Jun 23, 2026
6c4d354
Merge branch 'main' into feature/solcap-read-trigger
Unheilbar Jul 13, 2026
c7fc30f
Plex 3282 add cursor pagination sol trigger (#696)
Unheilbar Jul 27, 2026
10e1771
Bump common (#702)
Unheilbar Jul 29, 2026
18c7b87
add return slot on GetBalance endpoint (#697)
Unheilbar Jul 31, 2026
e6d5aa9
introduce limit on subkeys for solana log trigger
Unheilbar Aug 3, 2026
f3f044d
add comparers per subkey validation
Unheilbar Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions chain_capabilities/solana/trigger/trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ const (
SuffixLogTriggerFilterID = "-solana-log-trigger"
defaultQueryLimit = 1000
defaultMaxPagesPerPoll = 5
maxSubkeysPerTrigger = 4
maxComparersPerSubkey = 10
)

func publicKeyFromBytes(fieldName string, raw []byte) (solana.PublicKey, error) {
Expand Down Expand Up @@ -64,11 +66,16 @@ func validateFilterConfig(config *solanacappb.FilterLogTriggerRequest) error {
return fmt.Errorf("event idl json cannot be empty")
}

if len(config.Subkeys) > maxSubkeysPerTrigger {

@dhaidashenko dhaidashenko Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subkeys are 2d slices. Should we enforce a limit for both dimensions?

return fmt.Errorf("too many subkeys: maximum supported is %d, got %d", maxSubkeysPerTrigger, len(config.Subkeys))
}

if config.CpiFilterConfig != nil {
if _, err := publicKeyFromBytes("cpi filter destination address", config.CpiFilterConfig.DestAddress); err != nil {
return err
}
}

return validateSubkeyComparers(config.Subkeys)
}

Expand All @@ -77,6 +84,9 @@ func validateSubkeyComparers(subkeys []*solanacappb.SubkeyConfig) error {
if subkey == nil || len(subkey.Comparers) < 2 {
continue
}
if len(subkey.Comparers) > maxComparersPerSubkey {
return fmt.Errorf("subkey %d has too many comparers: %d limit: %d", i, len(subkey.Comparers), maxComparersPerSubkey)
}

eqValues := make(map[string]struct{})
for _, comp := range subkey.Comparers {
Expand Down
18 changes: 18 additions & 0 deletions chain_capabilities/solana/trigger/trigger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,24 @@ func TestRegisterLogTrigger(t *testing.T) {
mockSolana.AssertExpectations(t)
})

t.Run("too many subkeys", func(t *testing.T) {
service, mockSolana := setupTest(t)
request := createTestRequest()
request.Subkeys = []*solanacappb.SubkeyConfig{
{Path: []string{"f1"}},
{Path: []string{"f2"}},
{Path: []string{"f3"}},
{Path: []string{"f4"}},
{Path: []string{"f5"}},
}

_, err := service.RegisterLogTrigger(ctx, testTriggerID, testRequestMetadata(), request)

require.NotNil(t, err)
assert.Contains(t, err.Error(), "maximum supported is 4")
mockSolana.AssertExpectations(t)
})

t.Run("register log tracking fails", func(t *testing.T) {
service, mockSolana := setupTest(t)
request := createTestRequest()
Expand Down
Loading