Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Walkthrough이번 변경 사항은 학기 정보(CURRENT_TERM) 관련 로직을 체계적으로 제거하는 일관된 리팩토링입니다. 다음과 같이 정리됩니다.
전체적으로 환경 변수 의존성을 제거하고 대학 이름 표시를 단순화하는 변경입니다. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NEXT_PUBLIC_CURRENT_TERM비교 분기를 제거하고 서버 응답의koreanName값을 그대로 사용하도록 정리했습니다.NEXT_PUBLIC_CURRENT_TERM항목을apps/web/.env에서 제거했습니다.CURRENT_TERM언급을 삭제해 현재 설정과 문서를 일치시켰습니다.Changed Files
apps/web/src/components/ui/UniverSityCard/index.tsxapps/web/src/app/university/[homeUniversity]/[id]/page.tsxapps/web/.env.env.guide.mdVerification
pnpm --filter @solid-connect/web run ci:checkpnpm --filter @solid-connect/web run build