Skip to content

fix: 대학 정보 표기의 CURRENT_TERM env 의존 제거 #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manNomi merged 2 commits into from
Feb 20, 2026
Merged

fix: 대학 정보 표기의 CURRENT_TERM env 의존 제거 #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aaf4bf
fix: 대학 홈 로고 카드 배경을 흰색으로 고정
manNomi Feb 18, 2026
80754cf
fix: 대학 학기 표시의 CURRENT_TERM env 의존 제거
manNomi Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
### `.env`
- **용도**: 모든 환경의 공통 기본값
- **커밋**: ✅ Git에 포함
- **내용**: 공통 설정 (CURRENT_TERM, IMAGE_URL 등)
- **내용**: 공통 설정 (IMAGE_URL 등)

### `.env.development`
- **용도**: 로컬 개발 환경 (`npm run dev`)
Expand Down
3 changes: 0 additions & 3 deletions apps/web/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# env
NEXT_PUBLIC_CURRENT_TERM=2025-2

# Shared configuration across all environments
# Environment-specific values are in .env.development, .env.preview, .env.production

Expand Down
5 changes: 1 addition & 4 deletions apps/web/src/app/university/(home)/_ui/HomeUniversityCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ const HomeUniversityCard = ({ university }: HomeUniversityCardProps) => {
href={`/university/${university.slug}`}
className="group flex items-center gap-5 rounded-2xl border border-k-100 bg-white p-5 transition-all hover:-translate-y-0.5 hover:border-primary-300 hover:shadow-lg"
>
<div
className="flex h-16 w-16 flex-shrink-0 items-center justify-center overflow-hidden rounded-full bg-k-50"
style={{ backgroundColor: `${university.color}10` }}
>
<div className="flex h-16 w-16 flex-shrink-0 items-center justify-center overflow-hidden rounded-full border border-k-100 bg-white">
<Image
src={university.logoUrl}
alt={`${university.name} 로고`}
Expand Down
10 changes: 2 additions & 8 deletions apps/web/src/app/university/[homeUniversity]/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,7 @@ export async function generateMetadata({ params }: PageProps): Promise<Metadata>
}

const homeUniversityInfo = getHomeUniversityBySlug(homeUniversity);
const convertedKoreanName =
universityData.term !== process.env.NEXT_PUBLIC_CURRENT_TERM
? `${universityData.koreanName}(${universityData.term})`
: universityData.koreanName;
const convertedKoreanName = universityData.koreanName;

const baseUrl = process.env.NEXT_PUBLIC_WEB_URL || "https://solid-connection.com";
const pageUrl = `${baseUrl}/university/${homeUniversity}/${id}`;
Expand Down Expand Up @@ -139,10 +136,7 @@ const CollegeDetailPage = async ({ params }: PageProps) => {

const universityData = universityDetailResult.data;

const convertedKoreanName =
universityData.term !== process.env.NEXT_PUBLIC_CURRENT_TERM
? `${universityData.koreanName}(${universityData.term})`
: universityData.koreanName;
const convertedKoreanName = universityData.koreanName;

const baseUrl = process.env.NEXT_PUBLIC_WEB_URL || "https://solid-connection.com";
const pageUrl = `${baseUrl}/university/${homeUniversity}/${collegeId}`;
Expand Down
5 changes: 1 addition & 4 deletions apps/web/src/components/ui/UniverSityCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ type UniversityCardProps = {
};

const UniversityCard = ({ university, showCapacity = true, linkPrefix = "/university" }: UniversityCardProps) => {
const convertedKoreanName =
university.term !== process.env.NEXT_PUBLIC_CURRENT_TERM
? `${university.koreanName}(${university.term})`
: university.koreanName;
const convertedKoreanName = university.koreanName;

return (
<Link
Expand Down