Fix Cursor pace detail when billing cycle quota is depleted#1824
Fix Cursor pace detail when billing cycle quota is depleted#1824Yuxin-Qiao wants to merge 1 commit into
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 2, 2026, 12:42 AM ET / 04:42 UTC. Summary Reproducibility: yes. from source inspection: current main computes Cursor billing-cycle pace for depleted windows, while the CLI and store paths already suppress pace when remaining percent is zero. I did not run live provider checks because repository policy warns against unrequested real account/keychain validation. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land the focused guard and regression test once normal required checks and maintainer merge review complete. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main computes Cursor billing-cycle pace for depleted windows, while the CLI and store paths already suppress pace when remaining percent is zero. I did not run live provider checks because repository policy warns against unrequested real account/keychain validation. Is this the best way to solve the issue? Yes, this is the narrow maintainable fix because it mirrors existing depleted-window suppression while preserving non-depleted Cursor pace details and adding a focused regression test. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6ab1cbb7daee. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04f5f1ff01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,188 +0,0 @@ | |||
| name: Monitor Upstream Changes | |||
There was a problem hiding this comment.
Restore the upstream monitor workflow
Deleting this file removes the only scheduled/manual GitHub Actions entry point for upstream checks, while the repo still documents using .github/workflows/upstream-monitor.yml and Actions → Monitor Upstream Changes in docs/FORK_SETUP.md and docs/UPSTREAM_STRATEGY.md. With this commit, maintainers no longer get the advertised upstream-sync issue updates unless the workflow is restored or the docs/scripts are updated to a replacement process.
Useful? React with 👍 / 👎.
7795ceb to
b0643a6
Compare
|
Addressed ClawSweeper feedback:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
remainingPercentreaches zero.UsageStore.weeklyPaceand CLI behavior so depleted quotas no longer show a misleading "Runs out now" / "即将耗尽" label.Behavior proof (redacted)
Live CLI (
CodexBarCLI usage --provider cursor, 2026-07-02)No pace / deficit / run-out lines are emitted for depleted lanes (matches CLI
remainingPercent > 0guard).Menu model regression (
swift test --filter CursorMenuCardModelTests)Depleted fixture asserts Total/Auto/API keep
0% leftwhiledetailLeftText,detailRightText, andpacePercentare allnil.Test plan
swift test --filter CursorMenuCardModelTests(4/4)make check