Pass unique context and cancel func to worker during compaction #8588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Tran <[email protected]>
anna-tran
added a commit
to anna-tran/thanos
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Anna Tran <[email protected]>
Signed-off-by: Anna Tran <[email protected]>
anna-tran
force-pushed
the
unique-worker-context
branch
from
0782fdf to
3030034
Compare
GiedriusS
reviewed
Dec 8, 2025
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Why cannot whoever calls Plan() cancel the context when they need to cancel it?
| comp tsdb.Compactor | ||
| } | ||
|
|
||
| var cancelFn = func() {} |
Member
There was a problem hiding this comment.
Could we please not add this? 🙏 let's pass func() {} instead where needed
Contributor
Author
There was a problem hiding this comment.
Yes I will fix this
Contributor
Author
This is also an option. We could make a new error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR creates a new context for each compaction worker and also passes the cancel function for that worker's context. This allows a single compaction to be aborted/failed in case of an issue in the planning phase, and only affect that single compaction job.
The change will help to address this issue in Cortex: cortexproject/cortex#7135
Verification
Updated unit tests.
make buildruns successfully.