🐛 Fix Windows test flakes and format blog SVGs#1145
Merged
Conversation
On Windows, tinyexec.kill('SIGINT') forcefully terminates the process
because Windows doesn't support POSIX signals. This kills the process
before ctrlc() can send a graceful CTRL_C_EVENT, so the finally block
never runs and stdout is empty.
Fix by only calling ctrlc() on Windows with SIGINT, skipping the
tinyexec.kill() that was preempting it.
commit: |
cowboyd
changed the title
In Windows CI, we don't reliably get 10 intervals in 50ms. Raise the timeout to half a second. This won't add time to the test because it passes as soon as 10 intervals are observed.
taras
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Three Windows CI issues that must land together — each fix alone still fails CI due to the other two:
Windows main test flake: The
maintests (gracefully shuts down on SIGINT,works even if suspend is the only operation) fail on Windows becausetinyexec.kill('SIGINT')forcefully terminates the process beforectrlc()can send a gracefulCTRL_C_EVENT. The subprocess dies before itsfinallyblock runs, so stdout is empty.Unformatted blog SVGs: SVGs added in Why JavaScript Needs Structured Concurrency #1103 and Add blog post: AbortController.abort() Doesn't Mean It Stopped #1111 were hand-authored and merged without running
deno fmt. This causesdeno fmt --checkto fail on Ubuntu CI.Windows interval test flake: The interval test uses a 50ms timeout, which isn't enough time to produce 10 intervals on Windows CI. The timeout fires before the intervals are observed.
Approach
test/suite.ts): On Windows with SIGINT, skiptinyexec.kill()and only callctrlc(pid). This lets the daemon receive the ctrl-c, run itsfinallyblock, and exit cleanly.www/blog/**/*.svg): Rundeno fmton the three affected files. Changes are purely whitespace.test/interval.test.ts): Increase timeout from 50ms to 500ms. No impact on test duration since the race resolves as soon as 10 intervals are observed.