chore: change reliable QoS settings #448
Draft
shmpwk wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 48.34% 48.34% -0.01%
==========================================
Files 156 156
Lines 12996 12997 +1
Branches 6901 6901
==========================================
Hits 6283 6283
- Misses 5326 5327 +1
Partials 1387 1387
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
This pull request updates the quality of service (QoS) settings for packet publishers in multiple decoder wrappers to ensure reliable message delivery. The main change is switching the QoS from the default sensor data profile to a reliable mode, which can help prevent packet loss in scenarios where message reliability is critical.
QoS reliability improvements:
nebula_packetspublisher inContinentalARS548DecoderWrapperto use.reliable()for reliable message delivery.nebula_packetspublisher inContinentalSRR520DecoderWrapperto use.reliable()for reliable message delivery.pandar_packetspublisher inHesaiDecoderWrapperto use.reliable()for reliable message delivery.Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks