Skip to content

chore: change reliable QoS settings #448

Draft
shmpwk wants to merge 1 commit into
tier4:mainfrom
shmpwk:tmp/change-qos-setting-for-secure-recording-v0.4.0
Draft

chore: change reliable QoS settings #448
shmpwk wants to merge 1 commit into
tier4:mainfrom
shmpwk:tmp/change-qos-setting-for-secure-recording-v0.4.0

Conversation

@shmpwk

@shmpwk shmpwk commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

PR Type

  • Improvement

Related Links

Description

This pull request updates the quality of service (QoS) settings for packet publishers in multiple decoder wrappers to ensure reliable message delivery. The main change is switching the QoS from the default sensor data profile to a reliable mode, which can help prevent packet loss in scenarios where message reliability is critical.

QoS reliability improvements:

  • Changed the QoS profile for the nebula_packets publisher in ContinentalARS548DecoderWrapper to use .reliable() for reliable message delivery.
  • Changed the QoS profile for the nebula_packets publisher in ContinentalSRR520DecoderWrapper to use .reliable() for reliable message delivery.
  • Changed the QoS profile for the pandar_packets publisher in HesaiDecoderWrapper to use .reliable() for reliable message delivery.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.34%. Comparing base (da35f1f) to head (0ef9d69).
⚠️ Report is 9 commits behind head on main.

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   48.34%   48.34%   -0.01%     
==========================================
  Files         156      156              
  Lines       12996    12997       +1     
  Branches     6901     6901              
==========================================
  Hits         6283     6283              
- Misses       5326     5327       +1     
  Partials     1387     1387              
Flag Coverage Δ
nebula_continental 30.37% <0.00%> (?)
nebula_hesai 30.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants