feat(nebula_core): vendor neutral runtime interface#450
Draft
drwnz wants to merge 20 commits into
Draft
Conversation
Signed-off-by: David Wong <david.wong@tier4.jp>
…s from review Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
…quired-requirement validation Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
…fy callback reentrancy contract Signed-off-by: David Wong <david.wong@tier4.jp>
…t use-after-free Signed-off-by: David Wong <david.wong@tier4.jp>
…CAN ID masking, drop counter wrap, double error reporting, and destructor lifecycle serialization Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
…cap fragment map, validate signatures, and tighten thread-safety contracts Signed-off-by: David Wong <david.wong@tier4.jp>
…tended-id, unify callback exception policy, and tighten router/reconfigure docs Signed-off-by: David Wong <david.wong@tier4.jp>
…header with thread-safety contract Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
d47166f to
5918981
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (16.80%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
- Coverage 40.19% 39.49% -0.70%
==========================================
Files 131 144 +13
Lines 10280 10638 +358
Branches 5393 5542 +149
==========================================
+ Hits 4132 4202 +70
- Misses 3796 4057 +261
- Partials 2352 2379 +27
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: David Wong <david.wong@tier4.jp>
60b3a8a to
89b5bee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
N/A
Description
This PR introduces a vendor-neutral runtime interface, providing a ROS-free core layer for
discovering sensor plugins, routing raw packets, and running decoders in live or replay sessions
without hard-coding vendor-specific orchestration.
The change adds:
nebula_core_common.nebula_core_decoders.SensorPluginMetadata.nebula_core_hw_interfaces.nebula_core_runtimepackage withSensorRegistry,PacketRouter,LiveTransportGraph, andReplaySessionRunner.graph composition, and replay behavior.
behavior, and migration expectations.
This PR is intentionally scoped to the common runtime contract and reference plumbing. It does
not convert the existing production sensor drivers to this interface. Hesai, Robosense,
Velodyne, Continental, and Seyond remain on their current driver paths. Production
SensorPluginandSensorDecoderRuntimeadapters should land in future vendor-specific PRs withsensor-specific tests and behavioral validation.
Runtime compatibility notes:
entrypoints.
kNebulaPluginAbiVersion.create_nebula_sensor_plugin,destroy_nebula_sensor_plugin, andnebula_plugin_abi_version.modelsentries must resolve to knownSensorModelvalues.destroysymbol when they use a non-default factory symbol.Review Procedure
Recommended review order:
nebula_core_commonandnebula_core_decoders.SensorRegistrydescriptor discovery, descriptor validation, ABI checks, shared-libraryownership, and plugin lifetime behavior.
PacketRouter,LiveTransportGraph, andReplaySessionRunnerfor routing semantics,lifecycle ordering, callback behavior, and replay/live consistency.
nebula_core_hw_interfaces, especially callback exceptionhandling and PCAP fragment reassembly.
path.
docs/vendor_neutral_runtime_interface.mdfor consistency with the implementation andstated migration scope.
Validation already run:
Results:
pre-commit: passed.git diff --check: passed.nebula_core_runtimeandnebula_sample_decoders: passed.nebula_core_common: passed 3/3 test executables.nebula_core_decoders: passed 4/4 test executables.nebula_core_runtime: passed 5/5 test executables, including the registry, router, live graph,replay runner, and sample plugin integration tests.
nebula_core_hw_interfaces: passed 5/5 test executables outside the restricted sandbox.Remarks
Follow-up work should add production adapters one vendor or sensor family at a time. Each adapter
should include live and replay validation for packet routing, calibration handling, configuration
translation, and output equivalence before any ROS wrapper is moved onto the runtime graph.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks