[pull] master from ruby:master#1053
Merged
Merged
Conversation
After 4bb1977 switched RCLASS_PRIME_CLASSEXT_WRITABLE_P to FL_TEST_RAW, GCC lost the RB_FL_ABLE-derived hint that klass is not a special const, and started warning that RCLASS_EXT_PRIME(klass) (used by the inlined RCLASS_WRITE_SUPER in class_associate_super) could yield a near-zero pointer. Make the existing VM_ASSERT(klass != 0) precondition visible to the optimizer via RBIMPL_ASSUME so the warning goes away without re-introducing the FL_TEST overhead. Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Bundler doesn't need to have an opinion on the current version of these tools. We can just include them without specific constraint, and if the user doesn't want the most recent version for some reason they can add the necessary constraint themselves. ruby/rubygems@5c080f0647
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )