Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/class.h
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ RCLASS_PRIME_CLASSEXT_WRITABLE_P(VALUE klass)
{
VM_ASSERT(klass != 0, "klass should be a valid object");
VM_ASSERT_BOXABLE_TYPE(klass);
RBIMPL_ASSUME(klass != 0);
return FL_TEST_RAW(klass, RCLASS_PRIME_CLASSEXT_WRITABLE);
}

Expand Down
17 changes: 0 additions & 17 deletions lib/bundler/cli/gem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ class CLI
end

class CLI::Gem
TEST_FRAMEWORK_VERSIONS = {
"rspec" => "3.0",
"minitest" => "5.16",
"test-unit" => "3.0",
}.freeze

DEFAULT_GITHUB_USERNAME = "[USERNAME]"

attr_reader :options, :gem_name, :thor, :name, :target, :extension
Expand Down Expand Up @@ -117,7 +111,6 @@ def run

if test_framework = ask_and_set_test_framework
config[:test] = test_framework
config[:test_framework_version] = TEST_FRAMEWORK_VERSIONS[test_framework]

case test_framework
when "rspec"
Expand Down Expand Up @@ -203,12 +196,10 @@ def run
config[:linter] = ask_and_set_linter
case config[:linter]
when "rubocop"
config[:linter_version] = rubocop_version
Bundler.ui.info "RuboCop enabled in config"
templates.merge!("rubocop.yml.tt" => ".rubocop.yml")
config[:ignore_paths] << ".rubocop.yml"
when "standard"
config[:linter_version] = standard_version
Bundler.ui.info "Standard enabled in config"
templates.merge!("standard.yml.tt" => ".standard.yml")
config[:ignore_paths] << ".standard.yml"
Expand Down Expand Up @@ -472,14 +463,6 @@ def required_ruby_version
"3.2.0"
end

def rubocop_version
"1.21"
end

def standard_version
"1.3"
end

def github_username(git_username)
if options[:github_username].nil?
git_username
Expand Down
6 changes: 3 additions & 3 deletions lib/bundler/templates/newgem/Gemfile.tt
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ gem "rake-compiler"
<%- end -%>
<%- if config[:test] -%>

gem "<%= config[:test] %>", ">= <%= config[:test_framework_version] %>"
gem "<%= config[:test] %>"
<%- end -%>
<%- if config[:linter] == "rubocop" -%>

gem "rubocop", ">= <%= config[:linter_version] %>"
gem "rubocop"
<%- elsif config[:linter] == "standard" -%>

gem "standard", ">= <%= config[:linter_version] %>"
gem "standard"
<%- end -%>
15 changes: 10 additions & 5 deletions spec/bundler/commands/newgem_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ def installed_go?
builder.eval_gemfile(bundled_app("#{gem_name}/Gemfile"))
builder.dependencies
rubocop_dep = builder.dependencies.find {|d| d.name == "rubocop" }
expect(rubocop_dep).not_to be_nil
expect(rubocop_dep).not_to be_specific
expect(rubocop_dep.requirement).to eq(Gem::Requirement.new([">= 0"]))
end

it "generates a default .rubocop.yml" do
Expand Down Expand Up @@ -239,7 +240,8 @@ def installed_go?
builder.eval_gemfile(bundled_app("#{gem_name}/Gemfile"))
builder.dependencies
standard_dep = builder.dependencies.find {|d| d.name == "standard" }
expect(standard_dep).not_to be_nil
expect(standard_dep).not_to be_specific
expect(standard_dep.requirement).to eq(Gem::Requirement.new([">= 0"]))
end

it "generates a default .standard.yml" do
Expand Down Expand Up @@ -746,13 +748,14 @@ def create_temporary_dir(dir)
expect(ignore_paths).to include("spec/")
end

it "depends on a specific version of rspec in generated Gemfile" do
it "depends on a non-specific version of rspec in generated Gemfile" do
allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
builder = Bundler::Dsl.new
builder.eval_gemfile(bundled_app("#{gem_name}/Gemfile"))
builder.dependencies
rspec_dep = builder.dependencies.find {|d| d.name == "rspec" }
expect(rspec_dep).not_to be_specific
expect(rspec_dep.requirement).to eq(Gem::Requirement.new([">= 0"]))
end
end

Expand Down Expand Up @@ -831,13 +834,14 @@ def create_temporary_dir(dir)
bundle "gem #{gem_name} --test=minitest"
end

it "depends on a specific version of minitest" do
it "depends on a non-specific version of minitest" do
allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
builder = Bundler::Dsl.new
builder.eval_gemfile(bundled_app("#{gem_name}/Gemfile"))
builder.dependencies
minitest_dep = builder.dependencies.find {|d| d.name == "minitest" }
expect(minitest_dep).not_to be_specific
expect(minitest_dep.requirement).to eq(Gem::Requirement.new([">= 0"]))
end

it "builds spec skeleton" do
Expand Down Expand Up @@ -892,13 +896,14 @@ def create_temporary_dir(dir)
bundle "gem #{gem_name} --test=test-unit"
end

it "depends on a specific version of test-unit" do
it "depends on a non-specific version of test-unit" do
allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
builder = Bundler::Dsl.new
builder.eval_gemfile(bundled_app("#{gem_name}/Gemfile"))
builder.dependencies
test_unit_dep = builder.dependencies.find {|d| d.name == "test-unit" }
expect(test_unit_dep).not_to be_specific
expect(test_unit_dep.requirement).to eq(Gem::Requirement.new([">= 0"]))
end

it "builds spec skeleton" do
Expand Down