Skip to content

fix(unikontainers): propagate actual errors instead of masking behind ErrNotUnikernel - #960

Open
safiya2610 wants to merge 2 commits into
urunc-dev:mainfrom
safiya2610:fix-issue-876
Open

fix(unikontainers): propagate actual errors instead of masking behind ErrNotUnikernel#960
safiya2610 wants to merge 2 commits into
urunc-dev:mainfrom
safiya2610:fix-issue-876

Conversation

@safiya2610

@safiya2610 safiya2610 commented Aug 11, 2026

Copy link
Copy Markdown

Description

Summary of Changes:
Updated GetUnikernelConfig error handling in pkg/unikontainers/unikontainers.go.

Instead of masking all configuration/decoding errors into ErrNotUnikernel, it now properly propagates the actual parsing/base64 decoding errors to the user. It only falls back to runc (via ErrNotUnikernel) specifically when os.ErrNotExist occurs (i.e., no configuration exists).

This prevents silent failures and makes debugging malformed configurations much easier.

Related issues

How was this tested?

Verified that malformed configurations correctly throw detailed parsing/decoding errors instead of failing silently and falling back to runc.

LLM usage

I used Google Gemini to help draft this pull request description.

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@netlify

netlify Bot commented Aug 11, 2026

Copy link
Copy Markdown

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 663f4f8
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6a818b926774570008442732

…ehind ErrNotUnikernel

Signed-off-by: safiya2610 <lci2023053@iiitl.ac.in>
@Nachiket-Roy

Copy link
Copy Markdown

Don't overwrite the PR template

@cmainas cmainas added invalid This doesn't seem right do-not-merge labels Aug 12, 2026
@safiya2610

Copy link
Copy Markdown
Author

Don't overwrite the PR template

cc @Nachiket-Roy @cmainas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Masked configuration/decoding errors cause silent fallback to runc and confusing failures

3 participants