Skip to content

fix(unikontainers): propagate actual errors instead of masking behind ErrNotUnikernel #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
safiya2610 wants to merge 2 commits into
base: main
Choose a base branch
from
+35 −1
Open

fix(unikontainers): propagate actual errors instead of masking behind ErrNotUnikernel #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
904d20b
fix(unikontainers): propagate actual errors instead of masking them b…
safiya2610 Aug 11, 2026
663f4f8
ci: fix CNI initialization in e2e tests
safiya2610 Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/vm_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,37 @@ jobs:
sudo mkdir -p /opt/cni/bin
sudo tar Cxzvf /opt/cni/bin "cni-plugins-linux-$(dpkg --print-architecture)-v${SAFE_CNI}.tgz"
rm -f "cni-plugins-linux-$(dpkg --print-architecture)-v${SAFE_CNI}.tgz"
sudo mkdir -p /etc/cni/net.d
sudo tee /etc/cni/net.d/10-containerd-net.conflist > /dev/null <<'EOF'
{
"cniVersion": "1.0.0",
"name": "containerd-net",
"plugins": [
{
"type": "bridge",
"bridge": "cni0",
"isGateway": true,
"ipMasq": true,
"promiscMode": true,
"ipam": {
"type": "host-local",
"ranges": [
[{
"subnet": "10.88.0.0/16"
}]
],
"routes": [
{ "dst": "0.0.0.0/0" }
]
}
},
{
"type": "portmap",
"capabilities": {"portMappings": true}
}
]
}
EOF

- name: Install nerdctl
env:
Expand Down
5 changes: 4 additions & 1 deletion pkg/unikontainers/unikontainers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ func New(bundlePath string, containerID string, rootDir string, cfg *UruncConfig

config, err := GetUnikernelConfig(bundlePath, spec)
if err != nil {
return nil, ErrNotUnikernel
if errors.Is(err, os.ErrNotExist) {
return nil, ErrNotUnikernel
}
return nil, err
}

confMap := config.Map()
Expand Down