Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Dec 23, 2025

Rename input parameters in step handlers for better clarity

This PR renames the input parameters in step handlers to improve clarity and better reflect their purpose:

  • Root steps (no dependencies) now use flowInput instead of input.run to directly access flow input
  • Dependent steps now use deps instead of input to access outputs from dependency steps
  • Context parameter is now consistently named ctx where used

These changes make the code more intuitive by:

  1. Clearly distinguishing between flow input and dependency outputs
  2. Using parameter names that better reflect their content
  3. Maintaining consistent naming conventions throughout the codebase

The changes affect example code in the documentation as well as actual implementation code, ensuring consistency across the entire project.

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: 4719c95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2025

View your CI Pipeline Execution ↗ for commit 4719c95

Command Status Duration Result
nx run edge-worker:test:integration ✅ Succeeded 3m 54s View ↗
nx affected -t verify-exports --base=origin/mai... ✅ Succeeded 3s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 3s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 2m 10s View ↗
nx run client:e2e ✅ Succeeded 1m 9s View ↗
nx run edge-worker:e2e ✅ Succeeded 48s View ↗
nx run cli:e2e ✅ Succeeded 3s View ↗
nx run core:pgtap ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-30 11:48:51 UTC

Copy link
Contributor Author

jumski commented Dec 30, 2025

Merge activity

  • Dec 30, 11:24 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 30, 11:42 AM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 30, 11:49 AM UTC: @jumski merged this pull request with Graphite.

@jumski jumski changed the base branch from 12-23-feat_asymmetric_handler_signatures_for_step_array_methods to graphite-base/557 December 30, 2025 11:33
@jumski jumski changed the base branch from graphite-base/557 to main December 30, 2025 11:40
@jumski jumski force-pushed the 12-23-migrate_48_files_from_input.run_to_asymmetric_handler_signatures branch from ad561ed to 4719c95 Compare December 30, 2025 11:41
@jumski jumski merged commit 2761b92 into main Dec 30, 2025
11 of 12 checks passed
@github-actions
Copy link
Contributor

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-557.pgflow.pages.dev

📝 Details:

  • Branch: 12-23-migrate_48_files_from_input.run_to_asymmetric_handler_signatures
  • Commit: 5f55a589877b2353e6debef143c29ddf90c1b890
  • View Logs

_Last updated: _

@github-actions
Copy link
Contributor

🚀 Production Deployment: Website

Successfully deployed to production!

🔗 Production URL: https://pgflow.dev

📝 Details:

  • Commit: 2761b92ef50dc7934eacf3959387b908f9a659b3
  • View Logs

Deployed at: 2025-12-30T12:49:26+01:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants