Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Dec 23, 2025

Simplify Step Input Structure for Better Context Access

This PR changes how inputs are passed to steps in a workflow:

  1. Removed the run key from step inputs:

    • Previously, all steps received the original flow input under a run key
    • Now, steps access the original flow input via context.flowInput instead
  2. Simplified input structure:

    • Root steps (with no dependencies) now receive an empty object {}
    • Dependent steps only receive outputs from their dependencies
  3. Updated documentation comments to reflect the new input structure:

    • Added examples for both root steps and dependent steps
    • Clarified that flow_input is available separately in the context
  4. Updated tests to verify the new input structure works correctly with:

    • Basic aggregation
    • Mixed dependencies
    • Multiple maps to single step

This change makes the input structure cleaner and more intuitive while ensuring all steps still have access to the original flow input when needed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: 440342c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2025

View your CI Pipeline Execution ↗ for commit 440342c

Command Status Duration Result
nx run edge-worker:test:integration ✅ Succeeded 5m 14s View ↗
nx run client:e2e ✅ Succeeded 1m 8s View ↗
nx run cli:e2e ✅ Succeeded 4s View ↗
nx affected -t verify-exports --base=origin/mai... ✅ Succeeded 3s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 3s View ↗
nx run edge-worker:e2e ✅ Succeeded 38s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 48s View ↗
nx run core:pgtap ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-23 23:24:26 UTC

@jumski jumski changed the base branch from 12-23-migrate_48_files_from_input.run_to_asymmetric_handler_signatures to graphite-base/558 December 23, 2025 15:26
@jumski jumski force-pushed the 12-23-remove_run_key_wrapper_from_step_task_input_construction branch from 7d18e09 to 697f365 Compare December 23, 2025 15:36
@jumski jumski changed the base branch from graphite-base/558 to 12-23-migrate_48_files_from_input.run_to_asymmetric_handler_signatures December 23, 2025 15:36
@jumski jumski force-pushed the 12-23-remove_run_key_wrapper_from_step_task_input_construction branch from 697f365 to a9a1da1 Compare December 23, 2025 16:05
@jumski jumski force-pushed the 12-23-remove_run_key_wrapper_from_step_task_input_construction branch from a9a1da1 to 440342c Compare December 23, 2025 23:15
@github-actions
Copy link
Contributor

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-558.pgflow.pages.dev

📝 Details:

  • Branch: 12-23-remove_run_key_wrapper_from_step_task_input_construction
  • Commit: 6c16026403fa4ab963f1d19a972b65f70fa42f31
  • View Logs

_Last updated: _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants