-
Notifications
You must be signed in to change notification settings - Fork 15
fix: reject empty dependsOn arrays and improve flowInput access patterns #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 12-25-feat_lazy_load_ctx.flowinput_to_prevent_data_duplication_for_map_steps
Are you sure you want to change the base?
Conversation
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit 3886c6c
☁️ Nx Cloud last updated this comment at |
ce2658e to
3886c6c
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-561.pgflow.pages.dev 📝 Details:
_Last updated: _ |

Prevent empty dependsOn arrays in Flow steps
This PR improves type safety by rejecting empty
dependsOn: []arrays at compile time. Empty dependency arrays are semantically meaningless (if a step has no dependencies, it should omitdependsOnentirely) and create a type mismatch between TypeScript and runtime behavior.The changes:
dependsOnarrays using the[Deps, ...Deps[]]syntaxctx.flowInputis lazy-loaded and should be awaitedconst flowInput = await ctx.flowInputThis change helps prevent a subtle bug where TypeScript would infer an empty object type for dependencies with
dependsOn: [], but at runtime the step would receive the flow input instead.